Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial API management CLI #2

Merged
merged 66 commits into from
Jun 2, 2021
Merged

Initial API management CLI #2

merged 66 commits into from
Jun 2, 2021

Conversation

svix-frank
Copy link
Contributor

No description provided.

@tasn
Copy link
Member

tasn commented May 29, 2021

🔥

Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making comments as conversations because that's the only way to have github actually track them. :|

It looks alright for all I managed to check without running it (due to the test url thing). Let me know once fixed and I can continue testing.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few small comments, but then it's ready to be merged. I haven't given it thorough testing, as I trust you that it works. It's the interface that I'm able to evaluate and I care the most about, so I focused on that. :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@svix-frank svix-frank requested a review from tasn June 2, 2021 13:37
@svix-frank svix-frank marked this pull request as ready for review June 2, 2021 13:39
Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some comments, let's fix them and get it merged!

.github/workflows/release.yml Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@svix-frank
Copy link
Contributor Author

One idea, should we maybe prefix them so they at least don't pollute the namespace?
E.g.: --data-name and --data-uid? for all of the data (content) ones?

Sounds reasonable, done!

@svix-frank svix-frank requested a review from tasn June 2, 2021 14:21
Copy link
Member

@tasn tasn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I squash, merge and release?

@svix-frank
Copy link
Contributor Author

Should I squash, merge and release?

Go for it =)

@tasn tasn merged commit 87d38ff into main Jun 2, 2021
@tasn
Copy link
Member

tasn commented Jun 2, 2021

Sweet! Now let's make a release (lmk how, just to tag it), update the docs website, and let's PARTY! :)

@svix-frank svix-frank deleted the frank/main branch June 2, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants