Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add completion function for generating shell completions #10

Merged
merged 1 commit into from
Jun 3, 2021
Merged

add completion function for generating shell completions #10

merged 1 commit into from
Jun 3, 2021

Conversation

svix-frank
Copy link
Contributor

completion.mov

@svix-frank svix-frank requested a review from tasn June 2, 2021 23:30
@svix-frank svix-frank requested a review from svix-liam June 2, 2021 23:34
svix-liam
svix-liam approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@svix-liam svix-liam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, trusting you on the shell config info

@svix-frank svix-frank merged commit d0b3698 into main Jun 3, 2021
@svix-frank svix-frank deleted the frank/completion branch June 3, 2021 01:58
@tasn
Copy link
Member

tasn commented Jun 3, 2021

Maybe add a section for it in the README?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svix-liam svix-liam svix-liam approved these changes

@tasn tasn Awaiting requested review from tasn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svix-frank @tasn @svix-liam