Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertion for empty docs in get_embeddings #200

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

iuliadmtru
Copy link
Contributor

Giving empty docs to get_embeddings throws ERROR: InexactError: trunc(Int64, NaN), which is not really suggestive. I added an assertion to make the error message clearer. I also added some unit tests.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.25%. Comparing base (e85e4ab) to head (b7ae834).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
+ Coverage   92.09%   92.25%   +0.15%     
==========================================
  Files          45       45              
  Lines        3997     4091      +94     
==========================================
+ Hits         3681     3774      +93     
- Misses        316      317       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svilupp svilupp merged commit 5b31403 into svilupp:main Aug 23, 2024
5 checks passed
@svilupp
Copy link
Owner

svilupp commented Aug 23, 2024

Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants