Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(extract): call path-to-posix less often #389

Merged
merged 1 commit into from
Nov 7, 2020

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Nov 6, 2020

Description

  • Moves converting paths to posix earlier in the process and removes the conversion where the conversion doesn't have any effect anymore.

Motivation and Context

See #386 - @tvolodimir put me on this trail that path-to-posix has an impact on performance. On msdos derivatives this refactor tends to make a significant difference in performance - on an i5 with win10 dependency-cruiser cruises itself in ~27s instead of in 32s (which is still ~3x as slow as it's on unix derivatives, but it's a start).

How Has This Been Tested?

  • automated non-regression tests + green ci

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation only change
  • Refactor (non-breaking change which fixes an issue without changing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • 📖

    • My change doesn't require a documentation update, or ...
    • it does and I have updated it
  • ⚖️

    • The contribution will be subject to The MIT license, and I'm OK with that.
    • The contribution is my own original work.
    • I am ok with the stuff in CONTRIBUTING.md.

@sverweij sverweij force-pushed the refactor/call-path-to-posix-less-often branch 7 times, most recently from c7f2542 to 152106f Compare November 7, 2020 10:49
on msdos derivatives this tends to make a significant difference in performance - on an i5 with win10 dependency-cruiser cruises itself in ~27s instead of in 32s
@sverweij sverweij force-pushed the refactor/call-path-to-posix-less-often branch from 152106f to 4330d82 Compare November 7, 2020 10:56
@codeclimate
Copy link

codeclimate bot commented Nov 7, 2020

Code Climate has analyzed commit 4330d82 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (99% is the threshold).

This pull request will bring the total coverage in the repository to 99.9% (0.0% change).

View more on Code Climate.

@sverweij sverweij merged commit 392991a into develop Nov 7, 2020
@sverweij sverweij deleted the refactor/call-path-to-posix-less-often branch November 7, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: released
Development

Successfully merging this pull request may close these issues.

1 participant