-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(*): add focus option #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 7574 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8429 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8432 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8430 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8446 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8634 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8634 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8811 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 8820 lines exceeds the maximum allowed for the inline comments feature.
b4a82e5
to
7e7c695
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 11169 lines exceeds the maximum allowed for the inline comments feature.
…ther filter options (exclude, doNotFollow which will help with future expansions, and makes code more maintainable because processing is more symmetrical
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 9463 lines exceeds the maximum allowed for the inline comments feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR diff size of 10002 lines exceeds the maximum allowed for the inline comments feature.
Code Climate has analyzed commit 7af2aa1 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (99% is the threshold). This pull request will bring the total coverage in the repository to 99.9% (0.0% change). View more on Code Climate. |
Description
focus
optionWhen you use this option, in the internal data structure each module grows a
matchesFocus
attribute that has the valuetrue
for modules in 1. ,false
for all modules. This can be helpful for e.g. use in graphical output (see the screenshots below for an example).focus: "^src/main"
) or as an object (focus: {path: "^src/main"}
)This makes sure processing for all filters is uniform, and can be extended easily (while remaining backwards compatible).
Motivation and Context
How Has This Been Tested?
Sample and screenshots
Example usage:
with this `.depcruise-options.js`
This demonstrates the use of the
matchesFocus
attribute to tweak the dot report. This colors the modules that directly match the 'focus' pattern green, and the rest lighgray:Which will yield:
For reference you can compare this with the complete internal dependency-graph, which you can find here
Types of changes
Checklist
📖
⚖️