build(eslint): add 'import' plugin

.eslintrc.json

@@ -3,7 +3,8 @@
     "plugins": [
         "security",
         "mocha",
-        "node"
+        "node",
+        "import"
     ],
     "parserOptions": {
         "ecmaVersion": 6,
@@ -279,7 +280,45 @@
         "node/no-unpublished-require": "error",
         "node/no-unsupported-features": "error",
         "node/process-exit-as-throw": "error",
-        "node/shebang": "error"
+        "node/shebang": "error",
+
+        // imports
+        "import/no-unresolved": "error",
+        "import/named": "error",
+        "import/default": "error",
+        "import/namespace": "error",
+        "import/no-stricted-paths": "off",
+        "import/no-absolute-path": "error",
+        "import/no-dynamic-require": "error",
+        "import/no-internal-modules": "off",
+        "import/no-webpack-loader-syntax": "error",
+
+        "import/export": "error",
+        "import/no-named-as-default": "error",
+        "import/no-named-as-default-member": "error",
+        "import/no-deprecated": "error",
+        "import/no-extraneous-dependencies": "error",
+        "import/no-mutable-exports": "error",
+
+        "import/unambiguous": "off",
+        "import/no-commonjs": "off",
+        "import/no-amd": "error",
+        "import/no-nodejs-modules": "off",
+
+        "import/first": "error",
+        "import/exports-last": "error",
+        "import/no-duplicates": "error",
+        "import/no-namespace": "error",
+        "import/extensions": "off",
+        "import/order": "error",
+        "import/newline-after-import": "error",
+        "import/prefer-default-export": "error",
+        "import/max-dependencies": ["error", {"max": 20}],
+        "import/no-unassigned-import": "error",
+        "import/no-named-default": "error",
+        "import/no-anonymous-default-export": "error"
+        // "import/group-exports": "error"
+
     },
     "env": {
         "node": true,

bin/dependency-cruise

@@ -2,9 +2,9 @@
 "use strict";
 
 const program    = require("commander");
+const semver     = require("semver");
 const processCLI = require("../src/cli");
 const $package   = require("../package.json");
-const semver     = require("semver");
 
 /* istanbul ignore if  */
 if (!semver.satisfies(process.versions.node, $package.engines.node)) {

package.json

@@ -11,8 +11,8 @@
   "scripts": {
     "depcruise": "./bin/dependency-cruise -X ^node_modules -x fixtures -v .dependency-cruiser-custom.json src bin/dependency-cruise test",
     "depcruise:graph": "./bin/dependency-cruise -x \"(^node_modules|^fs$|^path$)\" -T dot -v .dependency-cruiser-custom.json bin/dependency-cruise | dot -T svg > tmp_deps.svg",
-    "lint": "eslint bin src test",
-    "lint:fix": "eslint --fix bin src test",
+    "lint": "eslint bin/dependency-cruise src test",
+    "lint:fix": "eslint --fix bin/dependency-cruise src test",
     "nsp": "nsp check",
     "npm-check-updates": "ncu --upgrade",
     "postversion": "git push && git push --tags && npm publish",
@@ -42,6 +42,7 @@
     "chai-json-schema": "1.5.0",
     "coffee-script": "1.12.7",
     "eslint": "4.12.0",
+    "eslint-plugin-import": "^2.8.0",
     "eslint-plugin-mocha": "4.11.0",
     "eslint-plugin-node": "5.2.1",
     "eslint-plugin-security": "1.4.0",

src/cli/formatMetaInfo.js

@@ -1,8 +1,8 @@
 "use strict";
 
-const main     = require("../main");
 const chalk   = require('chalk');
 const figures = require('figures');
+const main    = require("../main");
 
 function bool2Symbol(pBool) {
     return pBool ? chalk.green(figures.tick) : chalk.red(figures.cross);

src/cli/index.js

@@ -1,12 +1,12 @@
 "use strict";
 
-const fs                 = require('fs');
+const fs                    = require('fs');
+const main                  = require('../main');
 const validateFileExistence = require('./validateFileExistence');
-const normalizeOptions   = require('./normalizeOptions');
-const initRules          = require('./initRules');
-const main               = require('../main');
-const formatMetaInfo     = require('./formatMetaInfo');
-const defaults           = require('./defaults.json');
+const normalizeOptions      = require('./normalizeOptions');
+const initRules             = require('./initRules');
+const formatMetaInfo        = require('./formatMetaInfo');
+const defaults              = require('./defaults.json');
 
 function writeToFile(pOutputTo, pDependencyString) {
     try {

src/extract/extract.js

@@ -1,10 +1,10 @@
 "use strict";
 
+const fs                          = require('fs');
+const path                        = require('path');
 const acorn                       = require('acorn');
 const acorn_loose                 = require('acorn/dist/acorn_loose');
-const fs                          = require('fs');
 const _                           = require('lodash');
-const path                        = require('path');
 const resolve                     = require('./resolve');
 const transpile                   = require('./transpile');
 const ignore                      = require('./ignore');

src/extract/gatherInitialSources.js

@@ -1,8 +1,9 @@
 const fs            = require('fs');
 const path          = require('path');
+const _defaults     = require('lodash/defaults');
 const ignore        = require('./ignore');
 const transpileMeta = require('./transpile/meta');
-const _defaults     = require('lodash/defaults');
+
 
 const SUPPORTED_EXTENSIONS = transpileMeta.scannableExtensions;
 

src/extract/resolve/resolve-AMD.js

@@ -1,8 +1,8 @@
 "use strict";
 
+const fs                       = require('fs');
 const path                     = require('path');
 const resolve                  = require('resolve');
-const fs                       = require('fs');
 const memoize                  = require('lodash/memoize');
 const determineDependencyTypes = require('./determineDependencyTypes');
 const readPackageDeps          = require('./readPackageDeps');

src/extract/transpile/coffeeWrap.js

@@ -13,3 +13,5 @@ module.exports = (pLiterate) => ({
         return coffeeScript.compile(pFile, lOptions);
     }
 });
+
+/* eslint import/order: off */

src/extract/transpile/liveScriptWrap.js

@@ -6,12 +6,14 @@ const livescript = tryRequire(
     require("../../../package.json").supportedTranspilers.livescript
 );
 
+/* istanbul ignore next */
 module.exports = {
     isAvailable: () => livescript !== false,
 
-    /* istanbul ignore next */
     transpile: pFile =>
         livescript.compile(
             pFile
         )
 };
+
+/* eslint import/order: off */

src/extract/transpile/meta.js

@@ -1,11 +1,11 @@
 "use strict";
 
+const supportedTranspilers = require("../../../package.json").supportedTranspilers;
 const javaScriptWrap       = require("./javaScriptWrap");
 const typeScriptWrap       = require("./typeScriptWrap");
 const liveScriptWrap       = require("./liveScriptWrap");
 const coffeeWrap           = require("./coffeeWrap")();
 const litCoffeeWrap        = require("./coffeeWrap")(true);
-const supportedTranspilers = require("../../../package.json").supportedTranspilers;
 
 /*
   jsx - acorn_loose will handle this correctly when imports

src/extract/transpile/tryRequire.js

@@ -38,4 +38,5 @@ module.exports = (pModuleName, pSemVer) => {
   eslint
     global-require: 0,
     security/detect-non-literal-require: 0
+    import/no-dynamic-require: 0
  */

src/extract/transpile/typeScriptWrap.js

@@ -19,3 +19,5 @@ module.exports = {
             }
         ).outputText
 };
+
+/* eslint import/order: off */

src/main/index.js

@@ -2,13 +2,13 @@
 
 const extract          = require("../extract");
 const meta             = require("../extract/transpile/meta");
-const validateRuleSet  = require("./ruleSet/validate");
-const normalizeRuleSet = require("./ruleSet/normalize");
 const reportHtml       = require("../report/htmlReporter");
 const reportJson       = require("../report/jsonReporter");
 const reportDot        = require("../report/dotReporter");
 const reportCsv        = require("../report/csvReporter");
 const reportErr        = require("../report/errReporter");
+const validateRuleSet  = require("./ruleSet/validate");
+const normalizeRuleSet = require("./ruleSet/normalize");
 const validateOptions  = require("./options/validate");
 const normalizeOptions = require("./options/normalize");
 

src/report/csvReporter.js

@@ -15,3 +15,5 @@ module.exports = pInput =>
             })
         }
     );
+
+/* eslint import/no-unassigned-import: 0 */

src/report/dotReporter.js

@@ -97,3 +97,5 @@ module.exports = (pInput) =>
             })
         }
     );
+
+/* eslint import/no-unassigned-import: 0 */

src/report/htmlReporter.js

@@ -31,3 +31,6 @@ module.exports = pInput =>
             })
         }
     );
+
+
+/* eslint import/no-unassigned-import: 0 */

test/cli/index.spec.js

@@ -1,11 +1,11 @@
 "use strict";
+const fs           = require("fs");
+const path         = require("path");
 const expect       = require('chai').expect;
+const intercept    = require("intercept-stdout");
 const processCLI   = require("../../src/cli");
-const fs           = require("fs");
 const tst          = require("../utl/testutensils");
 const deleteDammit = require("./deleteDammit.utl");
-const path         = require("path");
-const intercept    = require("intercept-stdout");
 
 const OUT_DIR      = "./test/cli/output";
 const FIX_DIR      = "./test/cli/fixtures";

test/cli/initRules.spec.js

@@ -1,11 +1,11 @@
 "use strict";
-const chai         = require('chai');
-const expect       = chai.expect;
 const fs           = require('fs');
-const deleteDammit = require("./deleteDammit.utl");
+const chai         = require('chai');
 const initRules    = require("../../src/cli/initRules");
 const rulesSchema  = require('../../src/main/ruleSet/jsonschema.json');
+const deleteDammit = require("./deleteDammit.utl");
 
+const expect       = chai.expect;
 const RULES_FILE = ".dependency-cruiser.json";
 
 chai.use(require('chai-json-schema'));

test/extract/index.spec.js

@@ -1,15 +1,16 @@
 "use strict";
 
 const chai                    = require('chai');
-const expect                  = chai.expect;
 const extract                 = require('../../src/extract');
+const depSchema               = require('../../src/extract/jsonschema.json');
 const cjsRecursiveFixtures    = require('./fixtures/cjs-recursive.json');
 const deprecationFixtures     = require('./fixtures/deprecated-node-module.json');
 const bundledFixtures         = require('./fixtures/bundled-dependencies.json');
 const amdRecursiveFixtures    = require('./fixtures/amd-recursive.json');
 const tsRecursiveFixtures     = require('./fixtures/ts-recursive.json');
 const coffeeRecursiveFixtures = require('./fixtures/coffee-recursive.json');
-const depSchema               = require('../../src/extract/jsonschema.json');
+
+const expect = chai.expect;
 
 chai.use(require('chai-json-schema'));
 

test/extract/resolve/readPackageDeps.spec.js

@@ -1,7 +1,7 @@
 "use strict";
 
-const expect = require("chai").expect;
 const path   = require("path");
+const expect = require("chai").expect;
 const read   = require("../../../src/extract/resolve/readPackageDeps");
 
 const FIXTUREDIR = "test/extract/resolve/fixtures/";

test/extract/transpile/coffeeWrap.spec.js

@@ -1,7 +1,7 @@
 "use strict";
 
-const expect  = require("chai").expect;
 const fs      = require('fs');
+const expect  = require("chai").expect;
 const wrap    = require("../../../src/extract/transpile/coffeeWrap")();
 const litWrap = require("../../../src/extract/transpile/coffeeWrap")(true);
 

test/extract/transpile/javascriptWrap.spec.js

@@ -1,7 +1,7 @@
 "use strict";
 
-const expect = require("chai").expect;
 const fs     = require('fs');
+const expect = require("chai").expect;
 const wrap   = require("../../../src/extract/transpile/javaScriptWrap");
 
 describe("jsx transpiler (the plain old javascript one)", () => {

test/extract/transpile/tryRequire.spec.js

@@ -1,8 +1,9 @@
 "use strict";
 
 const expect     = require("chai").expect;
-const tryRequire = require("../../../src/extract/transpile/tryRequire");
 const semver     = require('semver');
+const tryRequire = require("../../../src/extract/transpile/tryRequire");
+
 
 describe("transpiler tryRequire", () => {
     it("returns false for unresolvable modules", () => {

test/extract/transpile/typeScriptWrap.spec.js

@@ -1,7 +1,7 @@
 "use strict";
 
-const expect = require("chai").expect;
 const fs     = require('fs');
+const expect = require("chai").expect;
 const wrap  = require("../../../src/extract/transpile/typeScriptWrap");
 
 describe("typescript transpiler", () => {

test/main/main.spec.js

@@ -1,11 +1,12 @@
 "use strict";
 const chai       = require('chai');
-const expect     = chai.expect;
 const main       = require("../../src/main");
+const depSchema  = require('../../src/extract/jsonschema.json');
 const tsFixture  = require('./fixtures/ts.json');
 const tsxFixture = require('./fixtures/tsx.json');
 const jsxFixture = require('./fixtures/jsx.json');
-const depSchema  = require('../../src/extract/jsonschema.json');
+
+const expect     = chai.expect;
 
 chai.use(require('chai-json-schema'));
 

test/main/options/normalize.spec.js

@@ -1,5 +1,5 @@
-const normalizeOptions = require('../../../src/main/options/normalize');
 const expect           = require('chai').expect;
+const normalizeOptions = require('../../../src/main/options/normalize');
 
 describe("main/normalizeOptions", () => {
     it("ensures maxDepth is an int when passed an int", () => {

test/main/ruleSet/validate.spec.js

@@ -1,7 +1,7 @@
 "use strict";
+const fs       = require('fs');
 const expect   = require('chai').expect;
 const validate = require('../../../src/main/ruleSet/validate');
-const fs       = require('fs');
 
 describe("ruleSetReader", () => {
     it("bails out on scary regexps in paths", () => {

test/utl/testutensils.js

@@ -1,5 +1,5 @@
-const expect = require('chai').expect;
 const fs     = require("fs");
+const expect = require('chai').expect;
 
 module.exports = (() => {
     "use strict";

test/validate/index.spec.js

@@ -1,9 +1,9 @@
 "use strict";
+const fs               = require('fs');
 const expect           = require('chai').expect;
 const validate         = require('../../src/validate');
 const normalizeRuleSet = require('../../src/main/ruleSet/normalize');
 const validateRuleSet  = require('../../src/main/ruleSet/validate');
-const fs               = require('fs');
 
 function _readRuleSet(pFileName) {
     return normalizeRuleSet(