Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(report): enhance err html reporter #161

Merged
merged 4 commits into from
Jul 6, 2019

Conversation

sverweij
Copy link
Owner

@sverweij sverweij commented Jul 2, 2019

Description

  • make links from violation to the summary
  • include all the rules, even those with 0 violations - hidden by default

Motivation and Context

  • The links should make it easier to use.
  • Including all the rules gives a completer picture. I also like to think it can help in the process of defining rules & adoption in teams.

How Has This Been Tested?

  • automated non-regression tests
  • additional unit tests

Types of changes

  • New feature (non-breaking change which adds functionality)

Screenshots

show-non-violations

Checklist:

  • The code I add will be subject to The MIT license, and I'm OK with that.
  • The code I've added is my own original work.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sverweij sverweij force-pushed the feature/enhance-err-html-report branch from 51e21f5 to 6ef4232 Compare July 6, 2019 16:23
@codeclimate
Copy link

codeclimate bot commented Jul 6, 2019

Code Climate has analyzed commit 3274b24 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (99% is the threshold).

This pull request will bring the total coverage in the repository to 99.9% (0.0% change).

View more on Code Climate.

@sverweij sverweij changed the title WIP: feature(report): enhance err html reporter feature(report): enhance err html reporter Jul 6, 2019
@sverweij sverweij merged commit 0724b09 into develop Jul 6, 2019
@sverweij sverweij deleted the feature/enhance-err-html-report branch July 6, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: released
Development

Successfully merging this pull request may close these issues.

1 participant