Repository navigation
Scale status icons from 24px to 48px - #27
Merged
Merged
Conversation
2x nearest-neighbor pixel-doubling of the existing icons.h bitmaps (lossless for this art: every source shape sits on integer boundaries of the original 24-unit grid, so doubling each pixel is identical to re-rasterizing at 48x48 -- verified byte-for-byte against a script that does the doubling independently of the hand-written file). ICON_COL_RESERVE_FACTOR in layout_math.h doubled (1.65 -> 3.3) to match: it's defined as a multiple of the stat font size, not of the icon's own fixed pixel size, so doubling it exactly reproduces the original icon:gap:text ratio at every font-ladder rung instead of just whichever rung it happened to be tuned against. Verified: pio test -e native (90/90, test_icons updated for 48x48/288 bytes), pio run -e ee02 clean build, flashed to the physical EE02 and confirmed via /debug/key1 + /current -- icons render crisp and well-proportioned against the stat text, no clipping/overlap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2x nearest-neighbor pixel-doubling of the existing
icons.hbitmaps (lossless for this art: every source shape sits on integer boundaries of the original 24-unit grid, so doubling each pixel is identical to re-rasterizing at 48x48 — verified byte-for-byte against a script that does the doubling independently of the hand-written file).ICON_COL_RESERVE_FACTORinlayout_math.hdoubled (1.65 → 3.3) to match: it's defined as a multiple of the stat font size, not of the icon's own fixed pixel size, so doubling it exactly reproduces the original icon:gap:text ratio at every font-ladder rung instead of just whichever rung it happened to be tuned against.Verified:
pio test -e native(90/90,test_iconsupdated for 48x48/288 bytes),pio run -e ee02clean build, flashed to the physical EE02 and confirmed via/debug/key1+/current— icons render crisp and well-proportioned against the stat text, no clipping/overlap.