refactor(resolve): prefer exports condition over svelte field #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation, log packages while scanning deps instead
|
@bluwy noticed that if we prefer exports condition, we can actually rely on vite resolving the svelte field via mainFields. so we are able to get rid of the custom resolve logic completely. yay |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second step in the migration to exports condition.
Previously, the svelte field took precedence, now it is only used as a fallback if vite is unable to resolve a library.
The warning log and faq have been updated to reflect that library authors need to add the exports condition to remain compatible with future majors.
fixes #725