Skip to content

refactor: split resolve options phase #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 19, 2021
Merged

refactor: split resolve options phase #229

merged 11 commits into from
Dec 19, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 17, 2021

Fixes #228

This also fixes a bug I found inadvertently while refactoring this. For experimental.prebundleSvelteLibraries, its svelte compiler actually didn't account for preprocesors added by vite-plugin-svelte's addExtraPreprocessor() step. I've fixed this with a patch step in configResolved (😢), can't find a better way.

Todo: Tests

@bluwy bluwy marked this pull request as ready for review December 19, 2021 08:11
@bluwy bluwy merged commit 9c4c20e into main Dec 19, 2021
@bluwy bluwy deleted the refactor-resolve-options branch December 19, 2021 14:57
@github-actions github-actions bot mentioned this pull request Dec 19, 2021
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run production builds for non "production" mode
2 participants