Skip to content

ci: remove node version from cacheKey for actions/cache #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2021
Merged

ci: remove node version from cacheKey for actions/cache #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
fail-fast: false
matrix:
os: [ ubuntu-latest, windows-latest, macos-latest ]
node: [ 12, 14, 16 ]
node: [ 14 ]

steps:
- uses: actions/setup-node@v2
Expand All @@ -40,18 +40,18 @@ jobs:
id: pnpm-store
with:
path: ${{ env.pnpm_store_path }}
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
key: ${{ matrix.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}

- name: pnpm-store-fallback
if: steps.pnpm-store.outputs.cache-hit != 'true'
uses: actions/cache@v2
id: pnpm-store-fallback
with:
path: ${{ env.pnpm_store_path }}
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-fallback-${{ hashFiles('**/pnpm-lock.yaml') }}
key: ${{ matrix.os }}-pnpm-store-fallback-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-fallback-
${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-
${{ matrix.os }}-pnpm-store-fallback-
${{ matrix.os }}-pnpm-store-
- name: install
if: steps.pnpm-store.outputs.cache-hit != 'true'
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
id: pnpm-store
with:
path: ${{ env.pnpm_store_path }}
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
key: ${{ matrix.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
- name: install pnpm
run: npm i -g pnpm@6
- name: set pnpm store-dir
Expand Down Expand Up @@ -119,7 +119,7 @@ jobs:
id: pnpm-store
with:
path: ${{ env.pnpm_store_path }}
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
key: ${{ matrix.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
- name: install pnpm
run: npm i -g pnpm@6
- name: set pnpm store-dir
Expand Down Expand Up @@ -151,7 +151,7 @@ jobs:
id: pnpm-store
with:
path: ${{ env.pnpm_store_path }}
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
key: ${{ matrix.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}

- name: install pnpm
run: npm i -g pnpm@6
Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:
id: pnpm-store
with:
path: ${{ env.pnpm_store_path }}
key: ${{ matrix.os }}-node-v${{ matrix.node }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
key: ${{ matrix.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
- name: install pnpm
run: npm i -g pnpm@6
- name: set pnpm store-dir
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,18 @@ jobs:
id: pnpm-store
with:
path: ${{ env.pnpm_store_path }}
key: ubuntu-latest-node-v14-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
key: ubuntu-latest-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}

- name: pnpm-store-fallback
if: steps.pnpm-store.outputs.cache-hit != 'true'
uses: actions/cache@v2
id: pnpm-store-fallback
with:
path: ${{ env.pnpm_store_path }}
key: ubuntu-latest-node-v14-pnpm-store-fallback-${{ hashFiles('**/pnpm-lock.yaml') }}
key: ubuntu-latest-pnpm-store-fallback-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
ubuntu-latest-node-v14-pnpm-store-fallback-
ubuntu-latest-node-v14-pnpm-store-
ubuntu-latest-pnpm-store-fallback-
ubuntu-latest-pnpm-store-

- name: install
# install but don't run scripts, they could be evil
Expand Down