feat: enable optimizer for server environments during dev #1185
Conversation
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
| if (config.consumer === 'server' && optimizeDeps !== undefined) { | ||
| // optimizeDeps is not inherited by server environments so return it here | ||
| return { | ||
| optimizeDeps |
There was a problem hiding this comment.
not entirely happy with this for 2 reasons
-
this configuration part should probably be moved out of this plugin and into the setup-optimizer plugin, but that requires a bit of refactoring and maybe running vitefu twice.
-
it replicates the same optimizeDeps for server and client env, but i am not sure yet if the same rules apply
There was a problem hiding this comment.
it replicates the same optimizeDeps for server and client env, but i am not sure yet if the same rules apply
I was thinking the same thing. Would it be enough for us to just configure the extensions and plugins settings so that esbuild knows how to handle Svelte modules? Then, the user can decide what to include/exclude for optimizing themselves.
No description provided.