Skip to content

fix: resolve vite root before using it (fixes #113) #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2021
Merged

fix: resolve vite root before using it (fixes #113) #115

merged 1 commit into from
Jul 24, 2021

Conversation

dominikg
Copy link
Member

@dominikg dominikg commented Jul 24, 2021 •
edited
Loading

fixes #113

maybe vite should resolve root before calling config hook, that information is pretty crucial for plugins to read their own config files.

@dominikg dominikg merged commit 67c46ad into main Jul 24, 2021
@dominikg dominikg deleted the fix/resolve-custom-root branch July 24, 2021 15:16
@github-actions github-actions bot mentioned this pull request Jul 24, 2021
Merged
@ElMassimo ElMassimo mentioned this pull request Jan 6, 2022
Merged
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Internal server error" when root option for Vite is used
2 participants
@dominikg @bluwy