Skip to content

chore: replace querystring with URLSearchParams #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2021
Merged

chore: replace querystring with URLSearchParams #107

merged 2 commits into from
Jul 21, 2021

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 21, 2021

Fixes #106

Not sure of the performance implications, but it seems nice to avoid soon-to-be deprecated APIs.

@dominikg
Copy link
Member

thanks, that looks very clean. 👍

I think querystring needs to be removed from package.json and the lockfile aswell pnpm remove querystring in packages/vite-plugin-svelte should do

Performance wise it may have a small impact as its used in multiple hooks, but one less external dependency is a plus too.

@bluwy
Copy link
Member Author

bluwy commented Jul 21, 2021

Didn't notice it was part of the dependencies, I thought that was imported from Node's builtin modules. Will remove that too.

EDIT: Wait there's no querystring in the dependencies lol. It was actually using Node's builtin modules.

@dominikg dominikg merged commit ed2a22d into sveltejs:main Jul 21, 2021
@github-actions github-actions bot mentioned this pull request Jul 21, 2021
@benmccann
Copy link
Member

Thanks!!

@bluwy bluwy deleted the gh-106 branch July 24, 2021 03:18
@github-actions github-actions bot mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace querystring with URLSearchParams
3 participants