Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: props with dash #9964 #9993

Merged
merged 5 commits into from
Dec 27, 2023
Merged

fix: props with dash #9964 #9993

merged 5 commits into from
Dec 27, 2023

Conversation

adiguba
Copy link
Contributor

@adiguba adiguba commented Dec 23, 2023

Fix #9964

When using destructuring with renaming, the generated code can be incorrect when the original name is not a valid identifier.

Ex :

let {'data-test-id':a} =$props();

In the generated code, a will become $$props.data-test-id instead of $$props["data-test-id"]

For example, this code fail on current version, with an error "test is not defined" (REPL) :

<script>
	let {'data-test-id':a} =$props()
</script>

{a}

Same code with this fix : cloned REPL

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

There a lot of errors, but unrelated to this

Copy link

changeset-bot bot commented Dec 23, 2023

⚠️ No Changeset found

Latest commit: 6586e44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 23, 2023

@adiguba is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@trueadm trueadm merged commit 547ab93 into sveltejs:main Dec 27, 2023
6 checks passed
@adiguba adiguba deleted the fix-9964 branch September 16, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5 : props with dash
2 participants