-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
chore: tweak changeset #9667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: tweak changeset #9667
Conversation
|
Name | Type |
---|---|
svelte | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We're making everything a patch right now, not sure if that changes anything. Also, the message only relates to the new thing added, not the already existing things. So I'm tempted to leave it as is. |
In that case we we should update the changeset for #9609 before cutting the next release. I'll update this PR to do that
Agreed we should only mention new things. |
are you sure? All that PR did was apply the same behaviour to |
I think he meant compared to Svelte 4, where we did this check in prod, too, which we don't in Svelte 5 because the costs outweigh the theoretical benefits of catching a mismatch (for which you get a warning in dev anyway) |
I noticed we didn't mention that this applies to
src
andsrcset
as well, which I thought was important to mention. Not sure about the patch/ minor level. Feel free to keep that as patch if more appropriate