Skip to content

chore: tweak changeset #9667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023
Merged

chore: tweak changeset #9667

merged 3 commits into from
Nov 27, 2023

Conversation

benmccann
Copy link
Member

I noticed we didn't mention that this applies to src and srcset as well, which I thought was important to mention. Not sure about the patch/ minor level. Feel free to keep that as patch if more appropriate

Copy link

changeset-bot bot commented Nov 27, 2023

⚠️ No Changeset found

Latest commit: 61120b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-5-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 4:28pm

@dummdidumm
Copy link
Member

We're making everything a patch right now, not sure if that changes anything. Also, the message only relates to the new thing added, not the already existing things. So I'm tempted to leave it as is.

@benmccann
Copy link
Member Author

benmccann commented Nov 27, 2023

We're making everything a patch right now, not sure if that changes anything.

In that case we we should update the changeset for #9609 before cutting the next release. I'll update this PR to do that

Also, the message only relates to the new thing added, not the already existing things

Agreed we should only mention new things. src and srcset were previously hydrated if the client-side value were completely different (i.e. not equivalent when correcting for relative vs absolute). They no longer are after #9662

@Rich-Harris
Copy link
Member

src and srcset were previously hydrated if the client-side value were completely different (i.e. not equivalent when correcting for relative vs absolute)

are you sure? All that PR did was apply the same behaviour to href as currently applies to src

@dummdidumm
Copy link
Member

I think he meant compared to Svelte 4, where we did this check in prod, too, which we don't in Svelte 5 because the costs outweigh the theoretical benefits of catching a mismatch (for which you get a warning in dev anyway)

@Rich-Harris Rich-Harris merged commit 2660727 into main Nov 27, 2023
@Rich-Harris Rich-Harris deleted the benmccann-patch-1 branch November 27, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants