Skip to content

[docs] fix security warning in tutorial section Logic / Each blocks #7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

fredovecino
Copy link
Contributor

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

In the tutorial section "Logic / Each block" there is a warning in the editor:
Security: Anchor with "target=_blank" should have rel attribute containing the value "noreferrer" (13:6)

Affected page

REPL showing the fix

@baseballyama
Copy link
Member

Thank you for catching this!
I added your commit to #8024.
(So your name will list to commit log.👍)

So I will merge #8024 and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants