Skip to content

Feature/smart site update #5262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

antony
Copy link
Member

@antony antony commented Aug 12, 2020

Whilst working on the various PRs, I noticed that the update scripts are easily overlooked and don't produce meaningful errors, requiring diving into the readme.

This PR:

  • Names them consistently
  • Does some smarter checking regarding the need to run them locally or not
  • Always forces a run when building for production
  • Runs scripts in parallel where possible
  • Uses path.join rather than string concatenation where possible in the scripts.
  • Simplifies the readme instructions

Before submitting the PR, please make sure you do the following

  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.

@antony antony marked this pull request as draft August 12, 2020 22:10
@antony
Copy link
Member Author

antony commented Aug 12, 2020

Hm - I appear to have checked a cache dir in! Converted to draft whilst I fix.

@antony antony marked this pull request as ready for review August 12, 2020 22:14
@benmccann benmccann added the site label Aug 12, 2020
@antony antony requested a review from Conduitry August 12, 2020 23:41
@stale
Copy link

stale bot commented Jun 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale-bot label Jun 26, 2021
@stale stale bot removed the stale-bot label Jun 26, 2021
@stale stale bot removed the stale-bot label Jun 27, 2021
@benmccann benmccann force-pushed the feature/smart-site-update branch 2 times, most recently from df2d75a to cdc5f5c Compare July 12, 2021 18:34
@benmccann benmccann force-pushed the feature/smart-site-update branch from cdc5f5c to 6e7dd2c Compare July 12, 2021 18:38
@benmccann benmccann merged commit fdd3d4b into sveltejs:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants