Skip to content

Call onMount when connected & clean up when disconnected for custom element #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Feb 15, 2021
Merged

Call onMount when connected & clean up when disconnected for custom element #4522

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f2eb632
pseudo code
hontas Dec 18, 2019
6ebffd2
pseudo code
hontas Dec 18, 2019
7d9ff14
Merge branch 'master' of https://github.com/sveltejs/svelte
hontas Mar 6, 2020
0245239
cleanup
hontas Mar 7, 2020
72acf15
Merge remote-tracking branch 'upstream/master'
Jun 3, 2020
55559e6
Merge remote-tracking branch 'upstream/master'
Jun 9, 2020
b1fc702
Merge remote-tracking branch 'upstream/master'
hontas Jul 16, 2020
4730331
Merge branch 'master' of github.com:hontas/svelte
hontas Jul 18, 2020
297dfcc
Merge remote-tracking branch 'upstream/master'
hontas Jul 18, 2020
527c14d
Merge remote-tracking branch 'upstream/master'
hontas Oct 29, 2020
421f2cf
Merge branch 'master' of https://github.com/sveltejs/svelte
hontas Feb 11, 2021
9e78f39
get console output from puppeteer
hontas Mar 7, 2020
18334b4
custom element call onDestroy when disconnected
hontas Mar 7, 2020
a493b57
only call onDestroy callbacks
hontas Mar 7, 2020
7d9636f
lifecycle hooks and custom elements
Jun 3, 2020
95ad63f
simplify logic, trigger tests
Jun 4, 2020
90f5c0a
fix whitespace, trigger tests
Jun 4, 2020
628f80e
do not reset on_mount so that it can fire again if reinserted
hontas Jul 16, 2020
971ca91
simplify isCustomElement check
hontas Jul 16, 2020
9cc7dd2
remove whitespace
hontas Jul 16, 2020
1451a88
simpler isCustomElement & skip extra function call
hontas Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/master'
  • Loading branch information
Pontus Lundin committed Jun 9, 2020
commit 55559e652384c46cf5c43bb61da9015257cb03cb

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.