Skip to content

Allow transitions and animations to work within iframes #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 14, 2020
+129 −20
Merged

Allow transitions and animations to work within iframes #3625

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c9527f6
Allow transitions and animations to work within iframes
jacwright Sep 26, 2019
9f98b97
Updates names and saves 18 bytes.
jacwright Nov 19, 2019
655f801
Merge branch 'master' into gh-3624
jacwright Feb 28, 2020
db0e7e8
Fixing lint issues
jacwright Feb 28, 2020
4057e75
Removing crutch for leak
jacwright Feb 28, 2020
6d3be4a
Fix memory leaks.
jacwright Feb 29, 2020
71c397d
Merge branch 'master' into pr/3625
Conduitry Mar 14, 2020
8638f8e
update changelog
Conduitry Mar 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing crutch for leak 
I will add a ticket to document the leak.
  • Loading branch information
@jacwright
jacwright committed Feb 28, 2020
commit 4057e753be4b9812c5ee9f27beeaca6c6002824a
3 changes: 1 addition & 2 deletions src/runtime/internal/style_manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ export function delete_rule(node: Element & ElementCSSInlineStyle, name?: string
)
.join(', ');

active = Math.max(0, active - 1);
if (name && !active) clear_rules();
if (name && !--active) clear_rules();
}

export function clear_rules() {
Expand Down