Skip to content

Conversation

@Rich-Harris
Copy link
Member

fixes #17094

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Nov 1, 2025

🦋 Changeset detected

Latest commit: c1e814f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

Playground

pnpm add https://pkg.pr.new/svelte@17096

@dummdidumm dummdidumm merged commit 8ebbb3c into main Nov 1, 2025
18 checks passed
@dummdidumm dummdidumm deleted the gh-17094 branch November 1, 2025 22:35
@github-actions github-actions bot mentioned this pull request Nov 1, 2025
}
}

for (var symbol of Object.getOwnPropertySymbols(obj)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getOwnPropertySymbols() returns non-enumerable symbol keys as well. REPL

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can do just one loop over Reflect.ownKeys(obj) + check Object.propertyIsEnumerable.call(obj, key)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Symbol keys in state objects are not spread into rest props

4 participants