Skip to content

Conversation

Ocean-OS
Copy link
Member

Closes #16682

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 29, 2025

🦋 Changeset detected

Latest commit: 9d6e854

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16687

@sillvva
Copy link

sillvva commented Aug 29, 2025

There's a bug: https://svelte.dev/playground/25e885f15619494084ca088695e7d004?version=pr-16687

import 'svelte/internal/disclose-version';
import 'svelte/internal/flags/async';
import * as $ from 'svelte/internal/client';
import { writable } from "svelte/store";

export default function App($$anchor, $$props) {
	$.push($$props, true);

	$.async_body(async () => {
		const [$$stores, $$cleanup] = $.setup_stores();
		const $w = () => $.store_get(w, '$w', $$stores);
		let w = writable("store");

		(await $.save(Promise.resolve("test")))();

		if ($.aborted()) return;

		$.next();

		var text = $.text();

		$.template_effect(() => $.set_text(text, $w()));
		$.append($$anchor, text);
	});

	$.pop();
	$$cleanup(); // this is defined inside the async_body scope
}

@Ocean-OS
Copy link
Member Author

Found another bug, working on a fix.

@Ocean-OS Ocean-OS merged commit be645b4 into main Aug 30, 2025
17 checks passed
@Ocean-OS Ocean-OS deleted the gh-16682 branch August 30, 2025 19:52
@github-actions github-actions bot mentioned this pull request Aug 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top level await breaks stores as of 5.38.3
3 participants