fix: make effects depend on state created inside them #16198
Merged
+108
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Rich-Harris
approved these changes
Jun 18, 2025
Rich-Harris
pushed a commit
that referenced
this pull request
Jun 18, 2025
* chore: merge main into async branch * adjust test * fix: make effects depend on state created inside them (#16198) * make effects depend on state created inside them * fix, add github action * disable test in async mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want that behavior after all as we have realized - it's vital for thinks like a shared
Resourceclass instance which is scaffolded within the template, shares its instance across call sites, and should still trigger reruns when something changes (which can only happen if the surrounding template will rerun upon changes). Basically a revert of #15553 for effects.Also adds the possibility to run the suite in non-async-mode; we can use that to run a separate github action to make sure we don't accidentally regress.
merges into #16197 which in turn merges into the async branch