-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat: add command
and commandfor
to HTMLButtonAttributes
#16117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add command
and commandfor
to HTMLButtonAttributes
#16117
Conversation
🦋 Changeset detectedLatest commit: 7e79dc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I think we have to wait for these until they're out of Nightly (Firefox) and Technical Preview (Safari) -- we don't typically add APIs until they're mainlined into all of the main browsers. |
That's understandable. I was just excited to use it (😅) because I am working on an experimental SvelteKit app that fully works without JS. |
I think you can add defs for them on your end using this method: https://svelte.dev/docs/svelte/typescript#Enhancing-built-in-DOM-types Hope it works!! |
This is what I did for now. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is in the HTML spec, I think it makes sense to add
thank you! |
Add newly introduced
command
andcommandfor
attributes toHTMLButtonAttributes
.