Skip to content

feat: add command and commandfor to HTMLButtonAttributes #16117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

h4ckedneko
Copy link
Contributor

Add newly introduced command and commandfor attributes to HTMLButtonAttributes.

Copy link

changeset-bot bot commented Jun 9, 2025

🦋 Changeset detected

Latest commit: 7e79dc1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@elliott-with-the-longest-name-on-github
Copy link
Contributor

I think we have to wait for these until they're out of Nightly (Firefox) and Technical Preview (Safari) -- we don't typically add APIs until they're mainlined into all of the main browsers.

@h4ckedneko
Copy link
Contributor Author

That's understandable. I was just excited to use it (😅) because I am working on an experimental SvelteKit app that fully works without JS.

@elliott-with-the-longest-name-on-github
Copy link
Contributor

I think you can add defs for them on your end using this method: https://svelte.dev/docs/svelte/typescript#Enhancing-built-in-DOM-types

Hope it works!!

@h4ckedneko
Copy link
Contributor Author

I think you can add defs for them on your end using this method: https://svelte.dev/docs/svelte/typescript#Enhancing-built-in-DOM-types

Hope it works!!

This is what I did for now. Thank you.

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is in the HTML spec, I think it makes sense to add

@Rich-Harris Rich-Harris merged commit 292af8d into sveltejs:main Jun 11, 2025
@Rich-Harris
Copy link
Member

thank you!

@github-actions github-actions bot mentioned this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants