Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rewrite set_class() to handle directives #15352

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
+681 −328
Open

chore: rewrite set_class() to handle directives #15352

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
5576114
set_class with class: directives
adiguba Feb 21, 2025
42860b6
update expected result (remove leading space)
adiguba Feb 21, 2025
0073e0d
fix
adiguba Feb 21, 2025
2b3fb8e
optimize literals
adiguba Feb 21, 2025
1cbb44b
add test
adiguba Feb 21, 2025
2ae5869
add test for mutations on hydration
adiguba Feb 21, 2025
be008ae
clean observer
adiguba Feb 21, 2025
559c168
Update packages/svelte/src/compiler/phases/3-transform/client/visitor…
adiguba Feb 22, 2025
203ba37
Update packages/svelte/src/compiler/phases/3-transform/client/visitor…
adiguba Feb 22, 2025
412fe18
Update packages/svelte/src/compiler/phases/3-transform/client/visitor…
adiguba Feb 22, 2025
a4b7280
Update packages/svelte/src/compiler/phases/3-transform/server/visitor…
adiguba Feb 22, 2025
86fb42f
Update packages/svelte/src/internal/client/dom/elements/attributes.js
adiguba Feb 22, 2025
8f3c108
Update packages/svelte/src/internal/shared/attributes.js
adiguba Feb 22, 2025
bf9c305
remove unused + fix JSDoc
adiguba Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/svelte/src/internal/client/dom/elements/attributes.js 
nit

Co-authored-by: Rich Harris <hello@rich-harris.dev>
  • Loading branch information
@adiguba @Rich-Harris
adiguba and Rich-Harris authored Feb 22, 2025
commit 86fb42ff2279c33b888c39ec5de355b2afdfe274
4 changes: 2 additions & 2 deletions packages/svelte/src/internal/client/dom/elements/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,8 +258,8 @@ export function set_custom_element_data(node, prop, value) {
/**
* Spreads attributes onto a DOM element, taking into account the currently set attributes
* @param {Element & ElementCSSInlineStyle} element
* @param {Record<string|symbol, any> | undefined} prev
* @param {Record<string|symbol, any>} next New attributes - this function mutates this object
* @param {Record<string | symbol, any> | undefined} prev
* @param {Record<string | symbol, any>} next New attributes - this function mutates this object
* @param {string} [css_hash]
* @param {boolean} [preserve_attribute_case]
* @param {boolean} [is_custom_element]
Expand Down
Loading