Skip to content

fix: allow & to appear at the top when inside a :global(...) #13215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

dummdidumm
Copy link
Member

It's a valid CSS rule, which means "select the scope root": https://developer.mozilla.org/en-US/docs/Web/CSS/Nesting_selector#using_outside_nested_rule

Found out while reading up more on & as part of #13209

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 12, 2024

⚠️ No Changeset found

Latest commit: 9be1442

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

children[0].children[0].selectors.length > 1 ||
children[0].children[0].selectors[0].type !== 'PseudoClassSelector' ||
children[0].children[0].selectors[0].name !== 'global' ||
children[0].children[0].selectors[0].args?.children[0]?.children[0].selectors[0] !== node
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be written out better surely?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking of which...is the css AST a standard? It's a nightmare to work with it because everything is nested a 1000 level deep

Copy link
Member Author

@dummdidumm dummdidumm Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's modeled after the css-tree AST AFAIK; to my knowledge there's no real standard when it comes to CSS ASTs

This can be written out better surely?

moved the chain into a variable, but apart from that I don't see much more room to make it better - do you?

@dummdidumm dummdidumm merged commit 1a9d8a5 into main Sep 13, 2024
9 checks passed
@dummdidumm dummdidumm deleted the allow-nesting-selector-at-root branch September 13, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants