Skip to content

fix: avoid creating unnnecessary deriveds for text nodes with call #13206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

As per #13171 (comment) we were creating unnecessary deriveds in the compiled code.

This was a bit tricky to fix because in the RegularElement visitor we call build_template that if there's more than one call creates this deriveds and push them to the init. However in RegularElement if we realise that there's state the template that we just built is unused and we proceed to process the children which calls build_template again creating another set of deriveds (which this time will be actually pushed to the update).

To fix this i've splitted the logic to check how many states/calls are there in it's own function (used by build_template) so that i can use that function instead in RegularElement.

I went with snapshot tests because that's just unused code.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: b585e56

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm dummdidumm merged commit 3d5702a into main Sep 12, 2024
7 of 9 checks passed
@dummdidumm dummdidumm deleted the fix-unnecessary-deriveds branch September 12, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants