Skip to content

fix: don't show state_referenced_locally warning on types #13177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

Closes #13173

I had to add a ts-ignore because the types for the types declaration are not in the path types and i don't think they are worth adding.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 9, 2024

🦋 Changeset detected

Latest commit: 59f53d0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside compiler/index.js#compile we're stripping away type annotations before passing it on to the analysis phase etc - I think the better fix would be to strip those types there, i.e. investigate why they aren't removed within remove_typescript_nodes

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@paoloricciuti paoloricciuti changed the title fix: state_referenced_locally in types declarations fix: don't show state_referenced_locally warning on types Sep 10, 2024
@paoloricciuti
Copy link
Member Author

Inside compiler/index.js#compile we're stripping away type annotations before passing it on to the analysis phase etc - I think the better fix would be to strip those types there, i.e. investigate why they aren't removed within remove_typescript_nodes

Uh i missed this...gonna take a look 😉

@paoloricciuti
Copy link
Member Author

Inside compiler/index.js#compile we're stripping away type annotations before passing it on to the analysis phase etc - I think the better fix would be to strip those types there, i.e. investigate why they aren't removed within remove_typescript_nodes

We were simply missing a visitor for type annotations. Much better fix, thanks

@dummdidumm dummdidumm merged commit 941f83b into main Sep 10, 2024
9 checks passed
@dummdidumm dummdidumm deleted the fix-state-referenced-locally-types branch September 10, 2024 14:35
@dummdidumm
Copy link
Member

If we want to adjust this in the future, an alternative would be to adjust zimmerframe so that if you return null (for example) that this signals to zimmerframe "remove this node"

@paoloricciuti
Copy link
Member Author

If we want to adjust this in the future, an alternative would be to adjust zimmerframe so that if you return null (for example) that this signals to zimmerframe "remove this node"

That would be actually better and useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

state_referenced_locally warning appears on type guard
2 participants