Skip to content

chore: tidy up parser #13045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 27, 2024
Merged

chore: tidy up parser #13045

merged 7 commits into from
Aug 27, 2024

Conversation

Rich-Harris
Copy link
Member

Started working on #12925 and found a bunch of things we can improve first:

  • we should do as much validation during analysis, rather than parsing, as possible — it makes it much easier to (for example) have squigglies that cover a meaningful range, rather than being between two characters
  • we're generating every element twice! once for the opening tag, once for the closing tag. the second one just gets discarded. this is silly and wasteful and almost certainly my bad
  • the order of stuff in this file is all over the place. tidied it up — consts, export default, helper functions — rather than leaving everything weirdly interleaved

Aside from the squigglies, this doesn't change anything so I'll self-merge once green to unblock

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 27, 2024

🦋 Changeset detected

Latest commit: d9e52f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Another advantage of doing all validation during analysis is that language tools gets a proper Svelte AST in more cases

@Rich-Harris
Copy link
Member Author

great point! will try and move others over if I can, on a drive-by basis

@Rich-Harris Rich-Harris merged commit a1d1012 into main Aug 27, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the tidy-up-parser branch August 27, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants