Skip to content

chore: simpler fallback values #12788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 10, 2024
Merged

chore: simpler fallback values #12788

merged 7 commits into from
Aug 10, 2024

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Aug 10, 2024

Was reminded of this by #12781. We currently make things very complicated when rewriting destructuring patterns that have default values — this...

[a = await promise] = stuff();

...becomes this...

await (async () => {
  const tmp = stuff();

  (
    $.set(a, $.proxy(await $.value_or_fallback_async(tmp[0], async () => await promise)))
  );

  return tmp;
})();

As of #12780 it becomes this instead, which is simpler...

await (async ($$value) => (
  $.set(a, $.proxy(await $.value_or_fallback_async($$value[0], async () => await promise)))
))(stuff());

...but really it should just be this:

await (async ($$value) => (
  $.set(a, $.proxy(await $.fallback($$value[0], promise)))
))(stuff());

This PR makes a few changes:

  • it renames value_or_fallback to just fallback, and moves it to the shared directory since it's currently duplicated between server and client
  • it removes value_or_fallback_async, which doesn't do anything
  • it adds a build_fallback function instead of duplicating logic between the various places that need to create $.fallback code
  • it makes lazy fallback values the exception. If we have something [answer = 42], we don't need to wrap the 42 in a thunk
  • the same goes for await expressions — we don't need to wrap the fallback value in an async thunk it it's just something like await promise, we can just await the whole expression

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 10, 2024

🦋 Changeset detected

Latest commit: c38ac4e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 057316c into main Aug 10, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the simpler-fallback branch August 10, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants