Skip to content

fix: better event handling #12722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 41 commits into from
Aug 5, 2024
Merged

fix: better event handling #12722

merged 41 commits into from
Aug 5, 2024

Conversation

Rich-Harris
Copy link
Member

Found a couple of bugs in our event handling code, and in the process of fixing them concluded that the whole thing needed overhauling. There's lots of entangled logic and hard-to-follow indirection. Not yet completely happy with it but it's a lot better than it was

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Aug 3, 2024

🦋 Changeset detected

Latest commit: 986b048

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented Aug 4, 2024

It looks pretty good so far. Maybe you can make it ready for review and merge what we have already to unblock other work? I don't like keeping large refactors open as they block other work.

@Rich-Harris
Copy link
Member Author

yeah, that's fine — had hoped to get a bit more time to work on it before that would become a concern, but the days are short

@Rich-Harris Rich-Harris merged commit 59ea0b9 into main Aug 5, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the tidy-up-event-handling branch August 5, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants