-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
fix: better event handling #12722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: better event handling #12722
Conversation
🦋 Changeset detectedLatest commit: 986b048 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
It looks pretty good so far. Maybe you can make it ready for review and merge what we have already to unblock other work? I don't like keeping large refactors open as they block other work. |
yeah, that's fine — had hoped to get a bit more time to work on it before that would become a concern, but the days are short |
Found a couple of bugs in our event handling code, and in the process of fixing them concluded that the whole thing needed overhauling. There's lots of entangled logic and hard-to-follow indirection. Not yet completely happy with it but it's a lot better than it was
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint