Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix a typo and spelling in Svelte 5 breaking changes doc #12517

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

kyoshino
Copy link
Contributor

@kyoshino kyoshino commented Jul 21, 2024

Found a typo on the Svelte 5 Preview site — Breaking changes:

Both return an object with the exports of the component and potentially property accessors (if compiled with accesors: true).

This PR adds a missing “s” in accesors: true.

Also, it’s not a typo but there is an inconsistent spelling:

The change from classes towards functions is also reflected in the typings: SvelteComponent, the base class from Svelte 4, is deprecated in favor of the new Component type which defines the function shape of a Svelte component.

I believe Svelte docs are consistently written in British English (for example, the Runes page says “initialisation”, not “initialization”), and the Event handlers page does say “favour”. So I’ve added a “u” to “favor”.

Copy link

changeset-bot bot commented Jul 21, 2024

⚠️ No Changeset found

Latest commit: c6aa2d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kyoshino kyoshino changed the title docs: Fix a typo in Svelte 5 breaking changes doc: “accessors” docs: Fix a typo and spelling in Svelte 5 breaking changes doc Jul 21, 2024
@Rich-Harris Rich-Harris merged commit 0891fa7 into sveltejs:main Jul 21, 2024
0 of 2 checks passed
@Rich-Harris
Copy link
Member

thank you!

@kyoshino kyoshino deleted the patch-1 branch July 21, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants