Skip to content

chore: remove unnecessary Invalidator type #12354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

Rich-Harris
Copy link
Member

Via #12311 I noticed this is wrong — it doesn't take an argument, and by extension shouldn't take a type argument

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Jul 8, 2024

⚠️ No Changeset found

Latest commit: 5ced942

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris changed the title chore: fix Invalidator type chore: remove unnecessary Invalidator type Jul 8, 2024
@dummdidumm
Copy link
Member

dummdidumm commented Jul 9, 2024

@Conduitry do you remember why the private invalidator type ever optionally accepted a value? Looking at the corresponding store code it is indeed never called with a value.

@Rich-Harris
Copy link
Member Author

I imagine it was just a typo

@Rich-Harris Rich-Harris merged commit 12579d4 into main Jul 9, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the fix-invalidator-type branch July 9, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants