Skip to content

fix: adjust effect ordering #10777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: adjust effect ordering #10777

wants to merge 1 commit into from

Conversation

dummdidumm
Copy link
Member

This started out investigating a bug on the current preview site. When you navigate to the docs, then to something else than the introduction, then back to the introduction, you get an error. The culprit is the pre effects getting flushed by some render effect. We can fix this by adding a "is this legacy mode" check (which I removed in #10736; turns out we still need it). But then I realized that the whole logic is a bit flawed either way: Flushing render effects directly after pre effects and vice versa can get things out of order in runes mode, too. I've added a failing test in this PR. I don't have a good idea yet how to properly fix this, but I think it involves getting rid of the "eagerly flush this" and instead smartly inserting the render/pre effects in the right order, which means somehow honoring the currently flushed render/pre-effects when queuing new effects.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 21e5bce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member Author

closing in favor of #10783

@dummdidumm dummdidumm closed this Mar 13, 2024
@dummdidumm dummdidumm deleted the effect-ordering-fix branch March 13, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant