Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started out investigating a bug on the current preview site. When you navigate to the docs, then to something else than the introduction, then back to the introduction, you get an error. The culprit is the pre effects getting flushed by some render effect. We can fix this by adding a "is this legacy mode" check (which I removed in #10736; turns out we still need it). But then I realized that the whole logic is a bit flawed either way: Flushing render effects directly after pre effects and vice versa can get things out of order in runes mode, too. I've added a failing test in this PR. I don't have a good idea yet how to properly fix this, but I think it involves getting rid of the "eagerly flush this" and instead smartly inserting the render/pre effects in the right order, which means somehow honoring the currently flushed render/pre-effects when queuing new effects.
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint