Skip to content

breaking: preserve slots inside templates with a shadowrootmode attribute #10721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2024
Merged

breaking: preserve slots inside templates with a shadowrootmode attribute #10721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eleven-cycles-applaud.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"svelte": patch
---

breaking: preserve slots inside templates with a shadowrootmode attribute
20 changes: 19 additions & 1 deletion packages/svelte/src/compiler/phases/1-parse/state/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,23 @@ function parent_is_head(stack) {
return false;
}

/** @param {import('#compiler').TemplateNode[]} stack */
function parent_is_shadowroot_template(stack) {
// https://developer.chrome.com/docs/css-ui/declarative-shadow-dom#building_a_declarative_shadow_root
let i = stack.length;
while (i--) {
if (
stack[i].type === 'RegularElement' &&
/** @type {import('#compiler').RegularElement} */ (stack[i]).attributes.some(
(a) => a.type === 'Attribute' && a.name === 'shadowrootmode'
)
) {
return true;
}
}
return false;
}

const regex_closing_textarea_tag = /^<\/textarea(\s[^>]*)?>/i;
const regex_closing_comment = /-->/;
const regex_capital_letter = /[A-Z]/;
Expand Down Expand Up @@ -112,7 +129,8 @@ export default function tag(parser) {
? 'Component'
: name === 'title' && parent_is_head(parser.stack)
? 'TitleElement'
: name === 'slot'
: // TODO Svelte 6/7: once slots are removed in favor of snippets, always keep slot as a regular element
name === 'slot' && !parent_is_shadowroot_template(parser.stack)
? 'SlotElement'
: 'RegularElement';

Expand Down
7 changes: 7 additions & 0 deletions packages/svelte/tests/parser-modern/samples/template-shadowroot/input.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<template shadowrootmode="open">
<p><slot></slot></p>
</template>
<template>
<p><slot></slot></p>
</template>
<slot></slot>
160 changes: 160 additions & 0 deletions packages/svelte/tests/parser-modern/samples/template-shadowroot/output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,160 @@
{
"css": null,
"js": [],
"start": 0,
"end": 125,
"type": "Root",
"fragment": {
"type": "Fragment",
"nodes": [
{
"type": "RegularElement",
"start": 0,
"end": 66,
"name": "template",
"attributes": [
{
"type": "Attribute",
"start": 10,
"end": 31,
"name": "shadowrootmode",
"value": [
{
"start": 26,
"end": 30,
"type": "Text",
"raw": "open",
"data": "open"
}
]
}
],
"fragment": {
"type": "Fragment",
"nodes": [
{
"type": "Text",
"start": 32,
"end": 34,
"raw": "\n\t",
"data": "\n\t"
},
{
"type": "RegularElement",
"start": 34,
"end": 54,
"name": "p",
"attributes": [],
"fragment": {
"type": "Fragment",
"nodes": [
{
"type": "RegularElement",
"start": 37,
"end": 50,
"name": "slot",
"attributes": [],
"fragment": {
"type": "Fragment",
"nodes": [],
"transparent": true
}
}
],
"transparent": true
}
},
{
"type": "Text",
"start": 54,
"end": 55,
"raw": "\n",
"data": "\n"
}
],
"transparent": true
}
},
{
"type": "Text",
"start": 66,
"end": 67,
"raw": "\n",
"data": "\n"
},
{
"type": "RegularElement",
"start": 67,
"end": 111,
"name": "template",
"attributes": [],
"fragment": {
"type": "Fragment",
"nodes": [
{
"type": "Text",
"start": 77,
"end": 79,
"raw": "\n\t",
"data": "\n\t"
},
{
"type": "RegularElement",
"start": 79,
"end": 99,
"name": "p",
"attributes": [],
"fragment": {
"type": "Fragment",
"nodes": [
{
"type": "SlotElement",
"start": 82,
"end": 95,
"name": "slot",
"attributes": [],
"fragment": {
"type": "Fragment",
"nodes": [],
"transparent": true
}
}
],
"transparent": true
}
},
{
"type": "Text",
"start": 99,
"end": 100,
"raw": "\n",
"data": "\n"
}
],
"transparent": true
}
},
{
"type": "Text",
"start": 111,
"end": 112,
"raw": "\n",
"data": "\n"
},
{
"type": "SlotElement",
"start": 112,
"end": 125,
"name": "slot",
"attributes": [],
"fragment": {
"type": "Fragment",
"nodes": [],
"transparent": true
}
}
],
"transparent": false
},
"options": null
}