Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] Minimal modifications in update_keyed_each #6603

Open
hbirler opened this issue Jul 31, 2021 · 0 comments
Open

[idea] Minimal modifications in update_keyed_each #6603

hbirler opened this issue Jul 31, 2021 · 0 comments
Labels
compiler Changes relating to the compiler perf

Comments

@hbirler
Copy link
Contributor

hbirler commented Jul 31, 2021

Describe the problem

The problem that update_keyed_each needs to solve seems really similar to the problem hydration needs to solve, i.e. "How do we reorder nodes with the minimal number of operations possible?"

Describe the proposed solution

Maybe update_keyed_each could also benefit from the longest increasing subsequence logic from the hydration pull request #6395. Maybe both subsystems could reuse the same code, potentially reducing the code size and increasing keyed-each performance.

I currently don't have a lot of free time so I thought this might be interesting for someone else willing to look into it.

Alternatives considered

I have not fully analyzed the current update_keyed_each logic so it might be that it already does minimal operations given its requirements. In that case, I am sorry to have bothered you all :)

Importance

nice to have

@dummdidumm dummdidumm added compiler Changes relating to the compiler perf labels Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Changes relating to the compiler perf
Projects
None yet
Development

No branches or pull requests

2 participants