Skip to content

Unnecessary migration to legacy runner #13460

Closed
@benmccann

Description

@benmccann

Describe the bug

I don't know why they put assetGridWidth in curly brackets, but it's only ever set in that one place

  $: {
    assetGridWidth = isShowActivity ? globalWidth - (globalWidth < 768 ? 360 : 460) : globalWidth;
  }

I wonder if we should try to detect that? Or if it's too much effort? Another possibility might be to make an eslint rule for it and suggest people fix it before running the migration tool

Reproduction

https://github.com/immich-app/immich/blob/a019fb670e0c1edfea24cd6620e4eaecf54a0600/web/src/routes/(user)/albums/%5BalbumId%3Did%5D/%5B%5Bphotos%3Dphotos%5D%5D/%5B%5BassetId%3Did%5D%5D/%2Bpage.svelte#L140

Logs

No response

System Info

svelte 5 as of sep 30

Severity

annoyance

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions