Skip to content

svelte 5 accessors broken after svelte@5.0.0-next.96 #11228

Closed
@yanick

Description

@yanick

Describe the bug

It's probably already known and/or in flux, but just in case it can be of help: changing parameters via accessors was working fine up to svelte@5.0.0-next.96 (using https://github.com/testing-library/svelte-testing-library/blob/main/src/__tests__/rerender.test.js), when at version100 began to die hard with

 FAIL  src/__tests__/rerender.test.js [ src/__tests__/rerender.test.js ]
TypeError: Cannot read properties of undefined (reading 'source')
 ❯ Module.hmr node_modules/.pnpm/svelte@5.0.0-next.97/node_modules/svelte/src/internal/client/dev/hmr.js:16:11
     16|  }
     17| 
     18|  return (data.wrapper ??= /** @type {Component} */ (
       |       ^
     19|   (anchor, props) => {
     20|    let instance = {};

then at version 101 and up stop dying (yay!), but doesn't change the params anymore (sad panda).

Reproduction

git clone https://github.com/testing-library/svelte-testing-library
cd svelte-testing-library
pnpm install
pnpm add svelte@next
vitest src/__tests__/rerender.test.js

Logs

No response

System Info

See, e.g., https://github.com/testing-library/svelte-testing-library/actions/runs/8741149959/job/23986502306

Severity

annoyance

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions