Double decker nav #235
Merged
Double decker nav #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
On dark mode it looks particularly nice because of the different background colors of the nav and the file names etc bar. On desktop I can't decide whether or not it looks clean or too spacey/lost because there's no separation at all between the nav bar, the REPL control, and the file names etc |
|
tweaked it a little bit, the lower nav now has the same shadow that the single decker nav would normally have, providing that separation |
Merged
|
gonna go ahead and merge to unblock other work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. The basic idea is that instead of having two navs, stacked awkwardly, we have a double decker nav on the routes that need it — for now just the playground, but I can see this maybe working for the tutorial as well.
Has a few other style tweaks intended to get rid of some visual noise and make everything a bit more consistent.