Skip to content

fix: get the site building for the version-3 branch - #2076

Merged
teemingc merged 2 commits into
mainfrom
fix-version-3-deploy
Jul 4, 2026
Merged

teemingc merged 2 commits into
mainfrom
fix-version-3-deploy

Conversation

@teemingc

@teemingc teemingc commented Jul 3, 2026 •

Copy link
Copy Markdown
Member

Few fixes to try and get this building successfully again. Also requires merging sveltejs/cli#1160

@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
svelte-dev Ready Ready Preview Jul 3, 2026 5:35pm

## What's new in SvelteKit

- You can now pass your SvelteKit config directly to the Vite plugin, so a separate `svelte.config.js` is no longer required, as a preview of how Kit 3 will require config to live in `vite.config.js` (**2.62.0**, [Docs](https://svelte.dev/docs/kit/configuration), [#15944](https://github.com/sveltejs/kit/pull/15944))
- Experimental explicit environment variables let you declare and type your env vars in one place, as a preview of how `$env/*` will work in SvelteKit 3 (**2.63.0**, [Docs](https://svelte.dev/docs/kit/environment-variables#Explicit-environment-variables), [#15934](https://github.com/sveltejs/kit/pull/15934))

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This id doesn't exist on the version-3 branch so we may as well get rid of it

// this monstrosity is required for twoslash (which uses `require`) to work during prerendering.
// it is brittle and may not work in perpetuity but i'm not sure what a better solution would be
if (chunk.type === 'chunk' && chunk.name === 'renderer') {
return `import { createRequire } from 'node:module'; const require = createRequire(import.meta.url);`;

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workaround is no longer needed and is causing this build error https://vercel.com/svelte/svelte-dev/3do19ZkuWZBoM6FUC4fxDnJTzoRT#L682

@teemingc teemingc mentioned this pull request Jul 3, 2026
9 of 10 tasks
@teemingc
teemingc merged commit 2ee353a into main Jul 4, 2026
2 checks passed
@teemingc
teemingc deleted the fix-version-3-deploy branch July 4, 2026 04:40
Rich-Harris added a commit to sveltejs/kit that referenced this pull request Jul 7, 2026
closes #15406

Requires merging the following before the docs can build successfully:

- [x] sveltejs/svelte.dev#1845
- [x] sveltejs/svelte.dev#2075
- [x] sveltejs/svelte.dev#2076
- [x] sveltejs/cli#1160

---

### Please don't delete this checklist! Before submitting the PR, please
make sure you do the following:
- [x] It's really useful if your PR references an issue where it is
discussed ahead of time. In many cases, features are absent for a
reason. For large changes, please create an RFC:
https://github.com/sveltejs/rfcs
- [x] This message body should clearly illustrate what problems it
solves.
- [ ] Ideally, include a test that fails without this PR but passes with
it.

### Tests
- [x] Run the tests with `pnpm test` and lint the project with `pnpm
lint` and `pnpm check`

### Changesets
- [x] If your PR makes a change that should be noted in one or more
packages' changelogs, generate a changeset by running `pnpm changeset`
and following the prompts. Changesets that add features should be
`minor` and those that fix bugs should be `patch`. Please prefix
changeset messages with `feat:`, `fix:`, or `chore:`.

### Edits

- [x] Please ensure that 'Allow edits from maintainers' is checked. PRs
without this option may be closed.

---------

Co-authored-by: Rich Harris <richard.a.harris@gmail.com>

This branch was successfully deployed

1 active deployment
Preview — e39c6cee Deployed Jul 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants