chore: markdown rendering fixes #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- handle `@param` on properties - properly run markdown on `.js` files. Previously `.js` was treated as TS, which resulted in errors because the jsdoc was ignored. This was done this way because twoslash does not run on `js` by default, but there's a different way to make it still run on them while respecting jsdoc.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rich-Harris
approved these changes
Jan 7, 2025
dummdidumm
added a commit
to sveltejs/kit
that referenced
this pull request
Jan 7, 2025
needs adjustment because without it since sveltejs/svelte.dev#1094 it won't build anymore
dummdidumm
added a commit
to sveltejs/svelte
that referenced
this pull request
Jan 7, 2025
Rich-Harris
added a commit
to sveltejs/svelte
that referenced
this pull request
Jan 7, 2025
* docs: add code of files being tested closes #14900 * fix * Apply suggestions from code review Co-authored-by: Rich Harris <rich.harris@vercel.com> * Update documentation/docs/07-misc/02-testing.md Co-authored-by: Rich Harris <rich.harris@vercel.com> * Apply suggestions from code review Co-authored-by: Rich Harris <rich.harris@vercel.com> * rename import * from sveltejs/svelte.dev#1094 --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paramon properties.jsfiles. Previously.jswas treated as TS, which resulted in errors because the jsdoc was ignored. This was done this way because twoslash does not run onjsby default, but there's a different way to make it still run on them while respecting jsdoc.