Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compiler options under compilerOptions #159

Merged
merged 2 commits into from
Jan 16, 2021

Conversation

benmccann
Copy link
Member

This updates it to match rollup-plugin-svelte and also simplifies the code

@benmccann
Copy link
Member Author

@non25 @Smittyvb let me know what you think about this one

@non25
Copy link
Contributor

non25 commented Jan 16, 2021

@benmccann I think it is reasonable to unify configuration interface. 3.0.0 will be breaking anyway.
And knowing that rollup is more popular, less popular solutions should mimic its behavior.
We should not forget to update template-webpack once we've done moving code around.

I kinda like the conciseness of one less level of config indentation though.

@non25
Copy link
Contributor

non25 commented Jan 16, 2021

Also it is more clear when compilerOptions are its own thing. So its harder for problems like #85 to pop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants