fix: cleanup timeout to prevent leak (#252)

sveltejs · Oct 31, 2023 · d7d71ce · d7d71ce
1 parent 0a700a2
commit d7d71ce
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/.changeset/wicked-pots-whisper.md b/.changeset/wicked-pots-whisper.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/site-kit': patch
+---
+
+fix: cleanup timeout to prevent leak
diff --git a/packages/site-kit/src/lib/nav/PreloadingIndicator.svelte b/packages/site-kit/src/lib/nav/PreloadingIndicator.svelte
@@ -10,6 +10,9 @@
 	let visible = false;
 
 	onMount(() => {
+		/** @type {any} */
+		let timeout;
+
 		function next() {
 			visible = true;
 
@@ -19,10 +22,14 @@
 				duration: remaining + 0.1 > 0.15 ? 250 : 500 / remaining
 			});
 
-			if (remaining > 0.15) setTimeout(next, 500 / remaining);
+			if (remaining > 0.15) {
+				timeout = setTimeout(next, 500 / remaining);
+			}
 		}
 
-		setTimeout(next, 250);
+		timeout = setTimeout(next, 250);
+
+		return () => clearTimeout(timeout);
 	});
 </script>