wait for window load event before registering the service worker?

[evdama]

Hi guys,

I was wondering, should we wait for the window load event before registering the service worker as it seems to be common practice to do so?

if ('serviceWorker' in navigator) {
  window.addEventListener('load', function() {           //  <-- wait for window to load before registering the sw
    navigator.serviceWorker.register('/service-worker.js');
  });
}

Most service worker implementations I've seen do, sw libs like workbox do it as well so I was wondering if that small change is worth adding?
https://developers.google.com/web/tools/workbox/guides/service-worker-checklist

sapper/runtime/src/server/middleware/get_page_handler.ts

Line 278 in a52bdb2

script += `if('serviceWorker' in navigator)navigator.serviceWorker.register('${req.baseUrl}/service-worker.js');`;