Set the languageId to svelte #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonlyu123
reviewed
May 8, 2020
benmccann
force-pushed
the
languageId
branch
6 times, most recently
from
2c24753 to
f3d8e1e
Compare
|
I honestly don't know if any of the plugin's language services actually uses that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm guessing the
languageIdshouldn't be empty and was only set that way to get things off the groundhttps://code.visualstudio.com/docs/languages/identifiers suggests it should match the package.json:
language-tools/packages/svelte-vscode/package.json
Line 197 in 98fc363
This is the first step of #68