Skip to content

(docs) add troubleshooting about conflicting react types #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2020

Conversation

dummdidumm
Copy link
Member

#228

Cannot be fixed in the language-server because it would require us to add a baseUrl to the tsconfig.json, which would break every bundler setup which does not know about this.

@joelmukuthu I'm really sorry this cannot be fixed 😞 Could you read the docs change and tell me if it is understandable?

sveltejs#228

Cannot be fixed in the language-server because it would require us to add a baseUrl to the tsconfig.json, which would break every bundler setup which does not know about this.
Copy link

@joelmukuthu joelmukuthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Makes perfect sense. The only thing I'm wary of is recommending adoption of a hack, so I suggested a small change that indicates that :)

dummdidumm and others added 3 commits July 3, 2020 12:57
Co-authored-by: Joel Mukuthu <joelmukuthu@gmail.com>
@dummdidumm
Copy link
Member Author

Thanks for the suggestions! I adjusted the docs accordingly.

@dummdidumm dummdidumm merged commit 89aeffd into sveltejs:master Jul 3, 2020
@dummdidumm dummdidumm deleted the react-type-clash-doc branch July 3, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants