Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move fast-glob to devDependencies #2400

Merged
merged 2 commits into from
Jun 24, 2024
Merged

chore: move fast-glob to devDependencies #2400

merged 2 commits into from
Jun 24, 2024

Conversation

benmccann
Copy link
Member

ref #2397

feel free to close that issue when this is merge. I didn't automatically link it since multiple solutions were being proposed there

jasonlyu123
jasonlyu123 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@jasonlyu123 jasonlyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. This sounds like the best solution for now. Removing it from the bundle doesn't feel like a big gain.

dummdidumm
dummdidumm reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was always bundled, we just needlessly had it as a dependency since the beginning of time ... oops

@dummdidumm dummdidumm merged commit 397139b into sveltejs:master Jun 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm left review comments

@jasonlyu123 jasonlyu123 jasonlyu123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmccann @dummdidumm @jasonlyu123