(fix) don't rename props name when triggered in shorthand #1877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while figuring out #1863
If you trigger the rename in the shorthand of ComponentB in ComponentA, we'll check the props rename for ComponentA. And if they have the same name, for example
Because there might be two edits to the exact shorthand location. It sometimes became
name={name}
and sometimes becamena={nameme}
.I also fixed a problem when the rename is triggered in
export let
without type annotation or default. Rename won't update props usage. This is done in the same PR because this problem prevents the main issue from happening. Thus the added test won't fail even without the fix.