Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(site): give logo image a label and bump site-kit #9707

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

geoffrich
Copy link
Member

@geoffrich geoffrich commented Apr 19, 2023

Fixes a couple a11y issues on the SvelteKit site - see sveltejs/site-kit#107 for details on the site-kit a11y fixes

Fixes:

  • SvelteKit logo on homepage was not properly labelled
  • Dark mode toggle was incorrectly nested inside a <ul> (site-kit fix)
  • Dark mode toggle was not labelled properly (site-kit fix)
  • Mobile navigation did not have background set (site-kit fix)

@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023

⚠️ No Changeset found

Latest commit: 1258d6e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann merged commit fccd659 into master Apr 19, 2023
@benmccann benmccann deleted the grich/a11y-sitekit branch April 19, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants