Skip to content

Allow extending multiple other tsconfig in tsconfigs, typescript 5.0 #9413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Allow extending multiple other tsconfig in tsconfigs, typescript 5.0 #9413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f27a62
allow multiple extends in tsconfig
JeremyMoeglich Mar 12, 2023
54b5d2d
format
JeremyMoeglich Mar 12, 2023
83a6cea
add changeset
JeremyMoeglich Mar 12, 2023
d412c73
Apply suggestions from code review
dummdidumm Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/metal-pugs-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: allow tsconfig to extend multiple other tsconfigs
7 changes: 6 additions & 1 deletion packages/kit/src/core/sync/write_tsconfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,12 @@ function load_user_tsconfig(cwd) {
function validate_user_config(kit, cwd, out, config) {
// we need to check that the user's tsconfig extends the framework config
const extend = config.options.extends;
const extends_framework_config = extend && path.resolve(cwd, extend) === out;
const extends_framework_config =
typeof extend === 'string'
? path.resolve(cwd, extend) === out
: Array.isArray(extend)
? extend.some((e) => path.resolve(cwd, e) === out)
: false;

const options = config.options.compilerOptions || {};

Expand Down